Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling small/tiny piles of dust via material flags. #2595

Open
wants to merge 2 commits into
base: 1.20.1
Choose a base branch
from

Conversation

tomprince
Copy link
Contributor

What

Add a flag to avoid generating piles of dust for a material. This avoids the need to override GTCEuStartupEvents.materialModification to add the material to the ignore list (resulting in the configuration for the material being split into multiple places.

Implementation Details

This could have been two flags (and my original implementation was), but I suspect the most common use would be to simply remove both types of piles.

Outcome

Fixes #2514.

Potential Compatibility Issues

If a modpack has added tiny/small piles of lapotron dust, they'll need to adjust their code to continue to do that.

@tomprince tomprince requested a review from a team as a code owner December 20, 2024 01:04
@a-a-GiTHuB-a-a
Copy link
Contributor

It'd be interesting to split the flag into two flags—one for small dusts and one for tiny dusts.

This could allow for a massive purge of useless dust sizes while also allowing certain dusts (like GaS iirc) to take only one of the two forms.

@tomprince
Copy link
Contributor Author

I still have the branch with two flags on my machine, but so far I've received negative feedback on this and my other PR to support removing dust conveniently from the devs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to disable tiny/small dusts for custom materials added through KJS at the point of definition..
2 participants